martong added inline comments.
================ Comment at: clang/lib/AST/ASTImporter.cpp:4861 + ToUsingPack->setLexicalDeclContext(LexicalDC); + LexicalDC->addDeclInternal(ToUsingPack); + ---------------- Why don't we use `addDeclToContexts`? ================ Comment at: clang/unittests/AST/ASTImporterTest.cpp:925 + classTemplateSpecializationDecl(hasDescendant(usingPackDecl()))))))); +} + ---------------- Should we also check if the DeclContext and the Extensions are properly set? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125986/new/ https://reviews.llvm.org/D125986 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits