steplong added a comment. In D126023#3528077 <https://reviews.llvm.org/D126023#3528077>, @rnk wrote:
> I was unable to find any documentation for the meaning of AArch64 > addrspace(256), and I wasn't able to figure it out after studying the code in > llvm/lib/Target/AArch64 for ten minutes or so. The change seems fine, but > please add some documentation as a follow-up. X86 has some of its address > spaces documented here, not that this is the best place: > https://llvm.org/docs/CodeGenerator.html#x86-address-spaces-supported Hmm yea I don't think addrspace(256) is correct. I was using D31248 <https://reviews.llvm.org/D31248> as a reference and addrspace(256) makes sense for that patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126023/new/ https://reviews.llvm.org/D126023 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
