MaskRay added a comment. In D124751#3513513 <https://reviews.llvm.org/D124751#3513513>, @python3kgae wrote:
> In D124751#3513283 <https://reviews.llvm.org/D124751#3513283>, @MaskRay wrote: > >> Is there a specification or reference implementation stating that -E is used? >> >>> Option<["--", "/", "-"], "E", >> >> Do you need the prefix `--`? You may define something like `CLFlag`. I have >> missed previous patches, but if `/` options are not necessary, removing them >> will be the best to avoid collision with filenames starting with `/`. > > Unfortunately, '/' is necessary. dxc allow both '-' and '/' like 'CLFlag'. > Remove '/' means existing customers may need to change their command line to > compile hlsl. > And add '--' feels not hurt anyone, that's why I choose to add '--' to > work-around the conflict. OK. I guess you have a pre-existing implementation using `-E` and the upstreaming implementation wants to be compatible. I wonder why the new tool needs to reuse `clang/include/clang/Driver/Options.td`. ISTM it would be cleaner to use a new .td file. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124751/new/ https://reviews.llvm.org/D124751 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
