zixuan-wu added a comment. In D126451#3539656 <https://reviews.llvm.org/D126451#3539656>, @rengolin wrote:
> This looks good to me, but wait to make sure others see it, too. > > My reasons are: it is largely similar to RISCV implementation, it seems to > follow what I expected of the ABI (which is similar to other targets) and has > a large corpus of tests. > > I can't comment on the specifics of the ABI implementation (I haven't read > the ABI document *that* thoroughly), but as David said, issues will be picked > up by tests until the target reaches maturity. I don't think it is largely similar to RISCV implementation except for the code structure and test reuse. And the test result is big different. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126451/new/ https://reviews.llvm.org/D126451 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
