nickdesaulniers requested changes to this revision. nickdesaulniers added a subscriber: aaron.ballman. nickdesaulniers added a comment. This revision now requires changes to proceed.
Let's get this rebased on top of D126511 <https://reviews.llvm.org/D126511>. ================ Comment at: clang/docs/ClangCommandLineReference.rst:368 -Select straight-line speculation hardening scope +Select straight-line speculation hardening scope (AArch64/X86 only). <arg> must be 'all', 'none', 'retbr'(AArch64), 'blr'(AArch64), 'return'(X86), 'indirect-branch'(X86) ---------------- nickdesaulniers wrote: > MaskRay wrote: > > This file is generated occasionally. Please don't modify it. > ah, it's generated from the clang/include/clang/Driver/Options.td HelpText > for this option. Yeah, that should be updated. This hunk should still be removed. @aaron.ballman confirmed to me that: > we auto-generate that > documentation when doing a sphinx build, like we do for attributes and > diagnostics: > https://github.com/llvm/llvm-project/blob/d480f968ad8b56d3ee4a6b6df5532d485b0ad01e/clang/docs/CMakeLists.txt#L129 You're addition to the HelpText in clang/include/clang/Driver/Options.td is sufficient. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126137/new/ https://reviews.llvm.org/D126137 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
