sunfish added inline comments.

================
Comment at: clang/lib/CodeGen/CodeGenModule.cpp:6360
+      auto *GA = llvm::GlobalAlias::create("__main_void", F);
+      GA->setVisibility(F->getVisibility());
+    }
----------------
Can this use `GA->setVisibility(GlobalValue::HiddenVisibility)`? `__main_void` 
is an implementation detail, so in theory users shouldn't be setting 
interesting visibility attributes on it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75277/new/

https://reviews.llvm.org/D75277

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to