rsmith added inline comments.
================
Comment at: clang/lib/CodeGen/CodeGenModule.h:1480-1482
+ llvm::SmallPtrSetImpl<clang::Module *> &getEmittedDeferredDecls() {
+ return EmittedModuleInitializers;
+ }
----------------
This function name doesn't match its implementation.
================
Comment at: clang/lib/CodeGen/ModuleBuilder.cpp:136-165
+
+ std::unique_ptr<CodeGen::CodeGenModule> OldBuilder;
+ OldBuilder.swap(Builder);
+
M.reset(new llvm::Module(ExpandModuleName(ModuleName, CodeGenOpts), C));
Initialize(*Ctx);
+
----------------
Please can you move all of this logic into a method on `CodeGenModule` rather
than exposing its implementation details to `ModuleBuilder`?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D126781/new/
https://reviews.llvm.org/D126781
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
