eugenis added inline comments.

================
Comment at: clang/lib/Driver/ToolChains/Linux.cpp:767
+  if (IsAArch64) {
+    Res |= SanitizerKind::MemtagGlobals;
+  }
----------------
Hmm why are all the other memtag* not here?


================
Comment at: clang/lib/Sema/SemaDeclAttr.cpp:7892
 
+static bool isSanitizerThatUsesGlobals(StringRef Sanitizer) {
+  return Sanitizer == "address" || Sanitizer == "hwaddress" ||
----------------
Maybe "applies to globals"? On the other hand, MSan "applies" to globals but 
does not need this logic.

isSanitizerAttributeAllowedOnGlobals?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127163/new/

https://reviews.llvm.org/D127163

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to