sfantao added a comment. In http://reviews.llvm.org/D18172#472152, @jlebar wrote:
> Yeah, I'd say that in the absence of a rule, consistency with surrounding > code is king. Otherwise we're sending a message when we don't mean to be. > > I'm not at my machine, but my recollection is that most of the driver uses > final sparingly. But whatever the convention is we should do that, I think. True, `final` is not widely used in the driver. Again, I don't feel strongly about doing this one way or the other. For the moment, I'll update the diffs according to what Alexey requested. If you guys decide that I should do that differently, I'm happy to go to back to each review and update it accordingly. Thanks again! Samuel http://reviews.llvm.org/D18172 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
