maryammo added inline comments.
================
Comment at: clang/lib/Sema/SemaExpr.cpp:7715
+bool Sema::areAnyVectorTypesAltivec(QualType SrcTy, QualType DestTy) {
+ assert(DestTy->isVectorType() || SrcTy->isVectorType());
----------------
lei wrote:
> maryammo wrote:
> > amyk wrote:
> > > Can we add some brief documentation for this function, like what is done
> > > for other functions in this file?
> > sure
> feels like this should be written to just take either 1 param or multiple
> params via vararg.. since the 2 arg are not really related in any way.
I am not sure what you mean, can you please elaborate on that?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D126540/new/
https://reviews.llvm.org/D126540
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
