beanz added a comment.

For just the type alias, adding it during parsing would probably work. Where 
things get more complicated is we have a whole mess of other data types that 
we’ll need to add too eventually. One of the advantages of using an external 
sema source is that we can create incomplete records during initialization, and 
complete them when the sema source gets the callback from lookup. That gives us 
cheap and efficient lazy-initialization of our buffer types which (in DXC) has 
a huge impact on compile time.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128012/new/

https://reviews.llvm.org/D128012

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to