samestep marked 4 inline comments as done.
samestep added inline comments.
================
Comment at: clang/include/clang/Analysis/FlowSensitive/MatchSwitch.h:49
+template <typename DiagsT> struct DiagnoseState {
+ DiagnoseState(DiagsT &Diags, const Environment &Env)
+ : Diags(Diags), Env(Env) {}
----------------
sgatev wrote:
> Move this to Diagnosis.h?
I'd prefer to keep it in `MatchSwitch.h` alongside `TransferState`, unless we
plan to, e.g., move that type to `DataflowAnalysis.h`.
================
Comment at:
clang/include/clang/Analysis/FlowSensitive/Models/UncheckedOptionalAccessModel.h:76
+class UncheckedOptionalAccessDiagnosis {
+public:
----------------
sgatev wrote:
> Move this to a new UncheckedOptionalAccessDiagnosis.(h,cpp)?
OK! I'll do that next.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D127898/new/
https://reviews.llvm.org/D127898
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
