sgatev accepted this revision. sgatev added inline comments.
================ Comment at: clang/include/clang/Analysis/FlowSensitive/DataflowAnalysisContext.h:164-166 + /// Returns a pointer value that represents a null pointer. Calls + /// with `PointeeType` that are canonically equivalent will return the same + /// result. ---------------- ================ Comment at: clang/include/clang/Analysis/FlowSensitive/DataflowEnvironment.h:316-318 + /// Returns a pointer value that represents a null pointer. Calls + /// with `PointeeType` that are canonically equivalent will return the same + /// result. ---------------- ================ Comment at: clang/include/clang/Analysis/FlowSensitive/DataflowEnvironment.h:319 + /// result. + PointerValue &getOrCreateNullPointerValue(QualType PointeeType); + ---------------- Let's move this below `getThisPointeeStorageLocation` so that it's closer to related members. Same for the cpp file. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128056/new/ https://reviews.llvm.org/D128056 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
