aaron.ballman added a comment. In D109701#3606042 <https://reviews.llvm.org/D109701#3606042>, @vaibhav.y wrote:
> Thanks for your patience with the review as well! Likewise! > Just noticed that I need to add a link to revision in the commit messages as > well: (https://www.llvm.org/docs/Phabricator.html#committing-a-change) Yup, you'd link the commit message back to this review, like: `Differential Revision: https://reviews.llvm.org/D109701` > I will update the commit messages, but I cannot commit to the github repo. Ah, thank you for letting me know. I can land the changes on your behalf. What name and email address would you like me to use for patch attribution? (I probably won't land it until tomorrow at this point though.) > Regarding further work on validation and integration, I couldn't find any > documentation on how to work with stacked changes. Could you please direct me > to some documentation for that? You shouldn't need to use a patch stack once we land the changes in this review (because they'll then be on the main branch). As for documentation on stacked changes, I don't think we have any community specific documentation for it, so I'd recommend using your favorite search engine. If you still don't find much on it, we can discuss it more later. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109701/new/ https://reviews.llvm.org/D109701 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
