v.g.vassilev accepted this revision. v.g.vassilev added a comment. This revision is now accepted and ready to land.
LGTM, modulo the comment. ================ Comment at: clang/lib/Interpreter/IncrementalExecutor.h:46 llvm::Error runCtors() const; + llvm::Error cleanUp(); llvm::Expected<llvm::JITTargetAddress> ---------------- Can you document this function? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128589/new/ https://reviews.llvm.org/D128589 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits