thieta added a comment.

Fixed the test issue. Regarding `/Fo` bit - if you want I can change it to only 
handle `/o` in this if statement. I don't mind either way.



================
Comment at: clang/test/Driver/ast.c:30
+// Also check clang-cl since the driver is slightly different
+// RUN: %clang_cl -ccc-print-phases -emit-ast %s 2> %t
+// RUN: echo 'END' >> %t
----------------
hans wrote:
> This needs a `--` before `%s` otherwise clang-cl might interpret the filename 
> as a flag, e.g. if it starts with /Users which is common on Mac.
Fixed - will also fix the other tests in the same file as a NFC.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128409/new/

https://reviews.llvm.org/D128409

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to