[PATCH] D128649: [clang-cl] Accept a pragma alloc_text corner case accepted by MSVC

[Hans Wennborg via Phabricator via cfe-commits]

hans added inline comments.


================
Comment at: clang/lib/Sema/SemaAttr.cpp:811
       return;
     }
 
----------------
Since the pragma only applies to functions, maybe we should error here if the 
decl is not a FunctionDecl?


================
Comment at: clang/lib/Sema/SemaAttr.cpp:816
+      Decl *D = ND;
+      while (D != nullptr) {
+        if (auto *FD = dyn_cast<FunctionDecl>(D)) {
----------------
Instead of walking the decls, would checking isExternC() on the 
getCanonicalDecl() be enough?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128649/new/

https://reviews.llvm.org/D128649

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits