awarzynski added inline comments.

================
Comment at: clang/lib/Driver/ToolChain.cpp:185
       {"flang", "--driver-mode=flang"},
+      {"flang-new", "--driver-mode=flang"},
       {"clang-dxc", "--driver-mode=dxc"},
----------------
clementval wrote:
> Why do we need two lines here? Shouldn't we have a single line with the name 
> chosen by the cmake option?
That would require making this file "configurable" by CMake. That would be 
quite an intrusive design change, which IMO we should avoid.

Unless there's some easy way that I'm missing here?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125788/new/

https://reviews.llvm.org/D125788

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to