Hi Marshall, I reverted this in r274651, since it broke a bot. Feel free to re-commit it later.
Manman > On Jul 6, 2016, at 12:16 AM, Diana Picus via cfe-commits > <cfe-commits@lists.llvm.org> wrote: > > Hi Marhsall, > > This seems to be breaking our libcxx bot: > http://lab.llvm.org:8011/builders/libcxx-libcxxabi-arm-linux/builds/1126 > I'm a bit confused by that comment you removed, do we need to update > our bot in any way? > > Thanks, > Diana > > On 6 July 2016 at 08:28, Marshall Clow via cfe-commits > <cfe-commits@lists.llvm.org> wrote: >> Author: marshall >> Date: Wed Jul 6 00:28:44 2016 >> New Revision: 274605 >> >> URL: http://llvm.org/viewvc/llvm-project?rev=274605&view=rev >> Log: >> Fix typo in #ifdef, and re-enable tests now that the green-dragon bots are >> no more >> >> Modified: >> >> libcxx/trunk/test/std/utilities/meta/meta.unary/meta.unary.prop/is_constructible.pass.cpp >> >> Modified: >> libcxx/trunk/test/std/utilities/meta/meta.unary/meta.unary.prop/is_constructible.pass.cpp >> URL: >> http://llvm.org/viewvc/llvm-project/libcxx/trunk/test/std/utilities/meta/meta.unary/meta.unary.prop/is_constructible.pass.cpp?rev=274605&r1=274604&r2=274605&view=diff >> ============================================================================== >> --- >> libcxx/trunk/test/std/utilities/meta/meta.unary/meta.unary.prop/is_constructible.pass.cpp >> (original) >> +++ >> libcxx/trunk/test/std/utilities/meta/meta.unary/meta.unary.prop/is_constructible.pass.cpp >> Wed Jul 6 00:28:44 2016 >> @@ -103,11 +103,11 @@ int main() >> test_is_not_constructible<AbstractDestructor> (); >> >> // LWG 2560 -- postpone this test until bots updated >> -// test_is_not_constructible<void()> (); >> -// #if TEST_STD_VERS > 11 >> -// test_is_not_constructible<void() const> (); >> -// test_is_not_constructible<void() volatile> (); >> -// test_is_not_constructible<void() &> (); >> -// test_is_not_constructible<void() &&> (); >> -// #endif >> + test_is_not_constructible<void()> (); >> +#if TEST_STD_VER > 11 >> + test_is_not_constructible<void() const> (); >> + test_is_not_constructible<void() volatile> (); >> + test_is_not_constructible<void() &> (); >> + test_is_not_constructible<void() &&> (); >> +#endif >> } >> >> >> _______________________________________________ >> cfe-commits mailing list >> cfe-commits@lists.llvm.org >> http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits > _______________________________________________ > cfe-commits mailing list > cfe-commits@lists.llvm.org > http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
