NoQ added inline comments.

================
Comment at: test/Analysis/Inputs/system-header-simulator-cxx.h:349
@@ +348,3 @@
+    // No warning is expected as we are suppressing warning coming
+    // out of std::basic_string.
+    int z = 0;
----------------
You mean std::shared_ptr here?

Also, perhaps it's better to move this example into  separate fake method; if 
this header emulator is used in another test, wouldn't the author of that test 
be surprised to see that operator=() is modeled that way?


http://reviews.llvm.org/D22048



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to