sgatev accepted this revision.
sgatev added inline comments.
================
Comment at: clang/lib/Analysis/FlowSensitive/TypeErasedDataflowAnalysis.cpp:401
+ const TypeErasedDataflowAnalysisState &State) {
+ PostVisitStmt(Stmt.getStmt(), State);
+ });
----------------
Let's harmonize the arguments to `transferBlock` and
`runTypeErasedDataflowAnalysis`. I think in both cases we only need access to
the internal `Stmt` so there's no need to pass `CFGStmt` to `transferBlock`.
This way we can pass `PostVisitStmt` directly here without having to wrap it in
a lambda.
================
Comment at: clang/unittests/Analysis/FlowSensitive/TestingSupport.h:87-89
+ std::function<std::function<void(
+ const Stmt *, const TypeErasedDataflowAnalysisState &)>(ASTContext &)>
+ MakePostVisitStmt,
----------------
Why is this a function that returns a function? Couldn't it be simply a void
function, like `VerifyResults`?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D127898/new/
https://reviews.llvm.org/D127898
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
