aaron.ballman added a comment. The only things left to do are: regenerate the documentation by running clang/docs/tools/dump_ast_matchers.py and add a release note for the new matcher, but otherwise this looks good to me.
In D128103#3617156 <https://reviews.llvm.org/D128103#3617156>, @NoQ wrote: > Yes the use case is coming up in D126097 <https://reviews.llvm.org/D126097>; > it's not used yet because `hasDescendant(StringLiteral)` is used to skip it > but this matchert would be a more precise solution (yes there's an actual > `StringLiteral` inside `ObjCStringLiteral`). Ah, great to hear this will be used quickly in tree too! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128103/new/ https://reviews.llvm.org/D128103 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
