MaskRay added inline comments.
================ Comment at: llvm/lib/Target/X86/X86AsmPrinter.cpp:125 + + // Emit int3 padding to allow runtime patching of the preamble. + EmitAndCountInstruction(MCInstBuilder(X86::INT3)); ---------------- A previous comment isn't done. This doesn't explain that the double-int3 before and after the identifier is an objtool requirement (or similar). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119296/new/ https://reviews.llvm.org/D119296 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
