Anastasia accepted this revision.
Anastasia added a comment.
This revision is now accepted and ready to land.
LGTM! Could you please address these last minor comments though before
committing.
Thanks!
================
Comment at: test/SemaOpenCL/access-qualifier.cl:10
@@ +9,3 @@
+#if __OPENCL_C_VERSION__ >= 200
+ typedef read_write image1d_t img1d_rw;
+#endif
----------------
don't indent here!
================
Comment at: test/SemaOpenCL/access-qualifier.cl:68
@@ +67,3 @@
+#else
+kernel void k13(__read_write image1d_t i){} // expected-error{{access
qualifier '__read_write' can not be used for '__read_write image1d_t' earlier
than OpenCL version 2.0}}
+#endif
----------------
It reads a bit strange. Would it be better:
"earlier than OpenCL version 2.0" -> "prior to OpenCL version 2.0"
http://reviews.llvm.org/D20948
_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
