sammccall marked an inline comment as done.
sammccall added inline comments.
================
Comment at: clang-tools-extra/pseudo/lib/cxx/CXX.cpp:54
+ return {
+ {(ExtensionID)Extension::Brackets, recoverBrackets},
+ };
----------------
hokein wrote:
> btw, it is annoying to write an explicit ExtensionID<=>Extension conversion.
> To avoid that, what do you think of making the Symbol&Extension as an `enum`
> rather than `enum class`, and we still keep the qualified name usage
> `Extension::Brackets`.
I don't find it particularly annoying FWIW.
I think I'd rather deal with this (which only appears in these tables, which
are regular) than implicit conversion and also polluting the namespace (even if
you only *use* Extension::Brackets, cxx::Brackets still exists, ends up in code
completion, can conflict with other symbols etc)
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D129158/new/
https://reviews.llvm.org/D129158
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
