MaskRay added a comment. I feel obliged to point out that the sheer number of updates is too large. Every update triggers an email to all reviewers and subscribers, so please be mindful. Personally I don't mind how many updates I receive, but others may do. It's usually not too bad to have too many reviewers (having too few reviewers can be more of a problem at times). I don't know how you added reviewers or whether you got upset after I clicked "Request Changes".
https://llvm.org/docs/CodeReview.html#lgtm-how-a-patch-is-accepted "Please also be mindful of weekends and major holidays." July 4 is a federal holiday in the United States, so many folks may not be responsive during the long weekend. (For my case I just finished my trip mode.) I haven't taken a second deep look at this patch but the `applyAlongResolverPath` change looks too intrusive to me. One previous version seems more favorable to me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129009/new/ https://reviews.llvm.org/D129009 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
