aaron.ballman requested changes to this revision.
aaron.ballman added a comment.
This revision now requires changes to proceed.

In http://reviews.llvm.org/D20352#477038, @rnk wrote:

> Looks good from a driver perspective. Aaron, you're happy with the attribute 
> spelling stuff, right?


No, I'm not. I am worried about how this conflicts with another in-flight patch 
for supporting MS hotpatchable functions since it seems these two attributes do 
roughly the same thing. I'd like to understand how these two user-facing 
attributes will not be confusing to users, what should happen if both 
attributes wind up on a function, etc. I am hoping that we can wind up with 
only one attribute that covers both cases, if possible.


http://reviews.llvm.org/D20352



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to