ChuanqiXu added a comment.

In D126694#3635207 <https://reviews.llvm.org/D126694#3635207>, @iains wrote:

> @rsmith, @ChuanqiXu apologies for the multiple revisions, this has turned out 
> to be much more involved than I imagined from the standard's text.
>
> In D126694#3629254 <https://reviews.llvm.org/D126694#3629254>, @ChuanqiXu 
> wrote:
>
>> In D126694#3629251 <https://reviews.llvm.org/D126694#3629251>, @iains wrote:
>>
>>> In D126694#3629094 <https://reviews.llvm.org/D126694#3629094>, @ChuanqiXu 
>>> wrote:
>>>
>>>> BTW, after I applied the patch, the compiler crashes at 
>>>> https://github.com/ChuanqiXu9/stdmodules.
>>>
>>> That link points to a project - is there (say) a gist of the crash 
>>> information?
>>
>> Here is the crash log:
>
> this code now compiles without error,

Thanks for looking into it!

My personal plan for this revision is to review the details after we add more 
large tests (at least we have a more complete std modules implementation and I 
am trying for it. But I find another bug now). So we might need to wait for a 
while for this patch. How do you think about it?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126694/new/

https://reviews.llvm.org/D126694

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to