psamolysov added a comment.
@aeubanks Hmm, if I correctly get your comment, I should revert this patch to
the state before the proposed solution with moving the
`PostOrderFunctionAttrsPass` at the end of the `buildInlinerPipeline` function
regardless of the `readonly` instead of `readnone` regression. Personally along
with your concern about compilation time, I have a concern about some changing
in coroutines compilation, the `Clang :: CodeGenCoroutines/coro-elide.cpp` test
demonstrates them:
// CHECK-NOT: %_Z5task1v.Frame = type {{.*}}%_Z5task0v.Frame
instead of
// CHECK: %_Z5task1v.Frame = type {{.*}}%_Z5task0v.Frame
I've reverted the latest changes because they require more investigation and,
as you said, should be introduced in a separate patch.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D128830/new/
https://reviews.llvm.org/D128830
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
