h-vetinari added a comment. Just comments, looks OK otherwise.
================ Comment at: clang/test/CMakeLists.txt:6 CLANG_BUILD_EXAMPLES + CLANG_BUILT_STANDALONE CLANG_DEFAULT_PIE_ON_LINUX ---------------- OT for this PR, but it would be nice to eventually rename this to `CLANG_BUILD_STANDALONE` in accordance with the present tense used for other variables. ================ Comment at: clang/test/lit.site.cfg.py.in:40 config.llvm_external_lit = path(r"@LLVM_EXTERNAL_LIT@") +config.stand_alone_build = @CLANG_BUILT_STANDALONE@ ---------------- I'd use one spelling of standalone / stand-alone, and I think in this case it's probably the env var that wins? ================ Comment at: clang/test/utils/update_cc_test_checks/lit.local.cfg:19 + # for any of the clang source code. + config.unsupported = True else: ---------------- I couldn't tell from the diff where this is used (though admittedly I hardly know the LLVM infra). I also don't see it in [[ https://github.com/llvm/llvm-project/blob/main/clang/test/lit.cfg.py | `lit.cfg.py` ]], the respective [[ https://github.com/llvm/llvm-project/blob/main/clang/test/CMakeLists.txt | `CMakeLists.txt` ]] or [[ https://github.com/llvm/llvm-project/blob/llvmorg-14.0.6/llvm/cmake/modules/AddLLVM.cmake#L1616 | `configure_lit_site_cfg` ]] I trust that this does what's intended. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123967/new/ https://reviews.llvm.org/D123967 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits