jhuber6 marked an inline comment as done.
jhuber6 added inline comments.

================
Comment at: clang/lib/Driver/ToolChains/Clang.cpp:7009
+  // Host-side offloading compilation receives all device-side outputs. Include
+  // them in the host compilation depending on the target.
   if ((IsCuda || IsHIP) && CudaDeviceInput) {
----------------
tra wrote:
> I think more details/history would be helpful here. Unlike you and me, the 
> future readers will have little to no context to understand why we do things 
> three different ways here.
I'd like a future with only one way of doing it, but I'll add a comment 
mentioning the new and old drivers to make it clearer.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129655/new/

https://reviews.llvm.org/D129655

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to