ASDenysPetrov closed this revision. ASDenysPetrov added a comment. Closed with bc08c3cb7f8e797fee14e96eedd3dc358608ada3 <https://reviews.llvm.org/rGbc08c3cb7f8e797fee14e96eedd3dc358608ada3>
================ Comment at: clang/test/Analysis/print-ranges.cpp:1 +// RUN: %clang_analyze_cc1 -analyzer-checker=core,debug.ExprInspection -analyzer-config eagerly-assume=false -verify %s +// REQUIRES: no-z3 ---------------- martong wrote: > Don't forget to pin the target/triple. Why does this specific test need it? ================ Comment at: clang/test/Analysis/print-ranges.cpp:1 +// RUN: %clang_analyze_cc1 -analyzer-checker=core,debug.ExprInspection -analyzer-config eagerly-assume=false -verify %s + ---------------- NoQ wrote: > ASDenysPetrov wrote: > > NoQ wrote: > > > I suspect this test will crash when clang is built with Z3, because the > > > Z3 constraint manager doesn't implement your new function yet. > > Agree. Is it enough `REQUIRES: no-z3` or to add `#ifdef ANALYZER_CM_Z3`? > That should be good. My personal tradition in such cases is to double-check > that this doesn't disable the test entirely. I added `REQUIRES: z3` it prints `Unsupported`, then added `REQUIRES: no-z3` and it passed. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129498/new/ https://reviews.llvm.org/D129498 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
