sebastian-ne added a comment.
Two comments inline, apart from that it looks good to me.
================
Comment at: cmake/Modules/FindPrefixFromConfig.cmake:30
+ if(IS_ABSOLUTE "${path_to_leave}")
+ set(prefix_var
+ "# Installation prefix is fixed absolute path"
----------------
Shouldn’t this set `config_code` instead of `prefix_var`, which is the output
variable in the generated code?
================
Comment at: cmake/Modules/FindPrefixFromConfig.cmake:32
+ "# Installation prefix is fixed absolute path"
+ "set(${prefix_var} \"${CMAKE_INSTALL_PREFIX}\"")
+ else()
----------------
This could use a comment to why it ignores `path_to_leave` and why
`CMAKE_INSTALL_PREFIX` is the correct choice.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D117973/new/
https://reviews.llvm.org/D117973
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
