sebastian-ne accepted this revision.
sebastian-ne added a comment.
This revision is now accepted and ready to land.
Looks good to me
================
Comment at: openmp/CMakeLists.txt:3
-# Add cmake directory to search for custom cmake functions.
-set(CMAKE_MODULE_PATH ${CMAKE_CURRENT_SOURCE_DIR}/cmake ${CMAKE_MODULE_PATH})
+set(LLVM_COMMON_CMAKE_UTILS ${CMAKE_CURRENT_SOURCE_DIR}/../cmake)
+
----------------
There are some places that surround this by an `if(NOT DEFINED
LLVM_COMMON_CMAKE_UTILS)` (e.g. lldb/cmake/modules/LLDBStandalone.cmake,
clang/CMakeLists.txt, polly/CMakeLists.txt) although other places don’t
(lld/CMakeLists.txt, libunwind/CMakeLists.txt, etc.), so both seem to be fine.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D130545/new/
https://reviews.llvm.org/D130545
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
