steakhal added a comment.
Other than nits, I think it looks great.
================
Comment at: clang/lib/StaticAnalyzer/Checkers/CStringChecker.cpp:1359
+void CStringChecker::evalMemcmp(CheckerContext &C, const CallExpr *CE,
+ bool IsWide) const {
// int memcmp(const void *s1, const void *s2, size_t n);
----------------
Personally, I dislike bools for this purpose.
Did you consider something like `enum CharacterFlavor {Regular, Wide}`? It
would be more readable in the CallDescription table.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D130470/new/
https://reviews.llvm.org/D130470
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
