bogner accepted this revision. bogner added a comment. This revision is now accepted and ready to land.
Fairly straightforward. LGTM with a couple of nits ================ Comment at: clang/include/clang/Sema/HLSLExternalSemaSource.h:48 + + // Complete an incomplete HLSL builtin type + void CompleteType(TagDecl *Tag) override; ---------------- This should be "///" for doxygen ================ Comment at: clang/test/AST/HLSL/RWBuffer-AST.hlsl:2 +// RUN: %clang_cc1 -triple dxil-pc-shadermodel6.0-library -x hlsl -fsyntax-only -ast-dump -DEMPTY %s | FileCheck -check-prefix=EMPTY %s +// RUN: %clang_cc1 -triple dxil-pc-shadermodel6.0-library -x hlsl -fsyntax-only -ast-dump %s | FileCheck %s + ---------------- Might be worth putting a comment at the top of this test explaining the difference between the two test modes here Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128569/new/ https://reviews.llvm.org/D128569 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
