ChuanqiXu added a comment. In D130614#3685142 <https://reviews.llvm.org/D130614#3685142>, @ilya-biryukov wrote:
> Thanks for the thorough explanation and testing. > LGTM. Thanks for reviewing! ================ Comment at: clang/lib/Sema/SemaDecl.cpp:1747 + + Module *NewM = New->getOwningModule(); + Module *OldM = Old->getOwningModule(); ---------------- ilya-biryukov wrote: > NIT: maybe accept the modules directly? I feel like the current style saves more typing. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130614/new/ https://reviews.llvm.org/D130614 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
