asb added inline comments.

================
Comment at: llvm/lib/Support/RISCVISAInfo.cpp:232
+bool RISCVISAInfo::hasVInstructions() const {
+  return hasExtension("zve32x");
+}
----------------
Given the other sub-thread showed that hasExtennsion("zve32x") == 
hasVInstructions isn't completely obvious, perhaps worth a comment like "zve32x 
is the root of the V extension inheritance tree. i.e. enabling any of the 
vector extensions will implicitly enable zve32x."


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130311/new/

https://reviews.llvm.org/D130311

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to