tstellar added inline comments.

================
Comment at: clang/test/utils/update_cc_test_checks/lit.local.cfg:19
+    # for any of the clang source code.
+    config.unsupported = True
 else:
----------------
h-vetinari wrote:
> I couldn't tell from the diff where this is used (though admittedly I hardly 
> know the LLVM infra). I also don't see it in [[ 
> https://github.com/llvm/llvm-project/blob/main/clang/test/lit.cfg.py | 
> `lit.cfg.py` ]], the respective [[ 
> https://github.com/llvm/llvm-project/blob/main/clang/test/CMakeLists.txt | 
> `CMakeLists.txt` ]] or [[ 
> https://github.com/llvm/llvm-project/blob/llvmorg-14.0.6/llvm/cmake/modules/AddLLVM.cmake#L1616
>  | `configure_lit_site_cfg` ]]
> 
> I trust that this does what's intended.
The lit tool uses this to decide whether or not to run the tests in the 
directory.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123967/new/

https://reviews.llvm.org/D123967

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to