aaron.ballman added inline comments.
================
Comment at: clang/test/AST/ast-dump-openmp-begin-declare-variant_11.c:2
// RUN: %clang_cc1 -triple x86_64-unknown-unknown -fopenmp -verify=c_mode
-ast-dump %s | FileCheck %s --check-prefix=C
-// RUN: %clang_cc1 -triple x86_64-unknown-unknown -fopenmp -verify=cxx_mode
-ast-dump %s -x c++| FileCheck %s --check-prefix=CXX
+// RUN: %clang_cc1 -triple x86_64-unknown-unknown -fopenmp -verify=cxx_mode
-ast-dump %s -x c++ -std=c++14 | FileCheck %s --check-prefix=CXX
----------------
I'm not really keen on this sort of change because it loses test coverage for
other language standard versions. We usually try to write our tests to be
standard version agnostic and only specify a specific language mode only when
absolutely necessary, which doesn't seem to be the case for a lot of the tests
in this patch (like this one).
================
Comment at: clang/test/CXX/basic/basic.stc/basic.stc.dynamic/p2.cpp:3
// RUN: %clang_cc1 -fsyntax-only -fexceptions -fcxx-exceptions -verify
-std=c++11 %s
-// RUN: %clang_cc1 -fsyntax-only -fexceptions -fcxx-exceptions -verify %s
+// RUN: %clang_cc1 -fsyntax-only -fexceptions -fcxx-exceptions -verify
-std=c++14 %s
int *use_new(int N) {
----------------
This is another example where we lose all testing in the future when we go to
change the default language standard version. It's fine to have a
C++14-specific test, but we should still have a test which has no mode
specified.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D131464/new/
https://reviews.llvm.org/D131464
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
