erichkeane added a comment.

I think this is fine.  I vaguely remember doing something like this in the 
past, but I can't seem to figure out what it was...



================
Comment at: clang/lib/AST/DeclBase.cpp:1037
+  assert(getDeclContext());
+  return getDeclContext()->getNonTransparentContext();
+}
----------------
so why are we calling this on our `DeclContext` here, which is the 'parent' of 
the current `Decl`?  Shouldn't this be casting itself to `DeclContext` and 
calling this function on it, so we don't end up 'skipping' the first parent?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131651/new/

https://reviews.llvm.org/D131651

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to