This revision was automatically updated to reflect the committed changes. Closed by commit rG42ee0d8c16f7: [clangd][unittests][IncludeCleaner] Don't call findReferencedFiles() if the… (authored by ArcsinX).
Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131706/new/ https://reviews.llvm.org/D131706 Files: clang-tools-extra/clangd/unittests/IncludeCleanerTests.cpp Index: clang-tools-extra/clangd/unittests/IncludeCleanerTests.cpp =================================================================== --- clang-tools-extra/clangd/unittests/IncludeCleanerTests.cpp +++ clang-tools-extra/clangd/unittests/IncludeCleanerTests.cpp @@ -571,9 +571,6 @@ )cpp"); ParsedAST AST = TU.build(); - auto ReferencedFiles = findReferencedFiles( - findReferencedLocations(AST), AST.getIncludeStructure(), - AST.getCanonicalIncludes(), AST.getSourceManager()); EXPECT_THAT(AST.getDiagnostics(), llvm::ValueIs(IsEmpty())); EXPECT_THAT(computeUnusedIncludes(AST), IsEmpty()); } @@ -596,9 +593,6 @@ )cpp"); ParsedAST AST = TU.build(); - auto ReferencedFiles = findReferencedFiles( - findReferencedLocations(AST), AST.getIncludeStructure(), - AST.getCanonicalIncludes(), AST.getSourceManager()); EXPECT_THAT(AST.getDiagnostics(), llvm::ValueIs(IsEmpty())); // FIXME: This is not correct: foo.h is unused but is not diagnosed as such // because we ignore headers with IWYU export pragmas for now.
Index: clang-tools-extra/clangd/unittests/IncludeCleanerTests.cpp =================================================================== --- clang-tools-extra/clangd/unittests/IncludeCleanerTests.cpp +++ clang-tools-extra/clangd/unittests/IncludeCleanerTests.cpp @@ -571,9 +571,6 @@ )cpp"); ParsedAST AST = TU.build(); - auto ReferencedFiles = findReferencedFiles( - findReferencedLocations(AST), AST.getIncludeStructure(), - AST.getCanonicalIncludes(), AST.getSourceManager()); EXPECT_THAT(AST.getDiagnostics(), llvm::ValueIs(IsEmpty())); EXPECT_THAT(computeUnusedIncludes(AST), IsEmpty()); } @@ -596,9 +593,6 @@ )cpp"); ParsedAST AST = TU.build(); - auto ReferencedFiles = findReferencedFiles( - findReferencedLocations(AST), AST.getIncludeStructure(), - AST.getCanonicalIncludes(), AST.getSourceManager()); EXPECT_THAT(AST.getDiagnostics(), llvm::ValueIs(IsEmpty())); // FIXME: This is not correct: foo.h is unused but is not diagnosed as such // because we ignore headers with IWYU export pragmas for now.
_______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
