The test cfe/trunk/test/Frontend/opencl.cl that was added here appears to fail.
Running "ninja check-clang" doesn't pick this up because cfe/trunk/test/Frontend/lit.local.cfg doesn't contain '.cl' as a file suffix: config.suffixes = ['.c', '.cpp', '.m', '.mm', '.ll'] As soon as I add the suffix: config.suffixes = ['.c', '.cpp', '.m', '.mm', '.ll', '.cl'] the test fails. The failure seems to happen because of the new "CHECK_INVALID_OPENCL_VERSION" checks. For OpenCL versions 1.1 and 1.2, compilation fails for these checks because of the expected error "blocks support disabled". A solution seems to be to add "-fblocks" to the command line for these two checks. I'll be sending a patch with this fix out for review shortly. On 13 July 2016 at 23:28, Yaxun Liu via cfe-commits < cfe-commits@lists.llvm.org> wrote: > This revision was automatically updated to reflect the committed changes. > Closed by commit rL275318: [OpenCL] Fixes failures in test/Driver/ > opencl.cl. (authored by yaxunl). > > Changed prior to commit: > http://reviews.llvm.org/D22170?vs=63722&id=63862#toc > > Repository: > rL LLVM > > http://reviews.llvm.org/D22170 > > Files: > cfe/trunk/lib/Frontend/CompilerInvocation.cpp > cfe/trunk/test/Driver/opencl.cl > cfe/trunk/test/Frontend/opencl-blocks.cl > cfe/trunk/test/Frontend/opencl.cl > > > _______________________________________________ > cfe-commits mailing list > cfe-commits@lists.llvm.org > http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits > > -- Martin Böhme Software Engineer mboe...@google.com +49 176 64059273 Google Germany GmbH Maria-Goeppert-Str. 3 23562 Lübeck Geschäftsführer: Matthew Scott Sucherman, Paul Terence Manicle Registergericht und -nummer: Hamburg, HRB 86891 Sitz der Gesellschaft: Hamburg Diese E-Mail ist vertraulich. Wenn Sie nicht der richtige Adressat sind, leiten Sie diese bitte nicht weiter, informieren Sie den Absender und löschen Sie die E-Mail und alle Anhänge. Vielen Dank. This e-mail is confidential. If you are not the right addressee please do not forward it, please inform the sender, and please erase this e-mail including any attachments. Thanks.
_______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
