samestep added inline comments.
================ Comment at: clang/lib/Analysis/FlowSensitive/Transfer.cpp:665 + if (!(Options.ContextSensitiveOpts && + Env.canDescend(Options.ContextSensitiveOpts->Depth, F))) return; ---------------- samestep wrote: > xazax.hun wrote: > > Alternatively, `canDescend` could get the optional `ContextSensitiveOpts` > > and we can do all the checking there. > Ah, good idea! Oh... actually that doesn't work quite so nicely, because it introduces a circular dependency between `Transfer.h` and `DataflowEnvironment.h`. I'll leave it as-is for now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131809/new/ https://reviews.llvm.org/D131809 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits