benlangmuir marked 2 inline comments as done.
benlangmuir added inline comments.


================
Comment at: clang/tools/clang-scan-deps/ClangScanDeps.cpp:403
+
+static std::string getModuleCachePath(ArrayRef<std::string> Args) {
+  for (StringRef Arg : llvm::reverse(Args)) {
----------------
jansvoboda11 wrote:
> Can you split this into separate patch?
This is hard because we don't have the association between input command-line 
and module dependencies in the previous code.  Per our offline discussion I've 
mentioned this in the commit message instead.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131934/new/

https://reviews.llvm.org/D131934

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to