tbaeder added inline comments.

================
Comment at: clang/lib/AST/ExprConstant.cpp:14938
+
+  if (E->getType().isNull())
+    return false;
----------------
shafik wrote:
> Curious why these two checks don't go w/ the `::Evaluate(Result, Info, E)` 
> below.
No real reason I think, it's just that from looking at them, they seem to make 
sense to me in the general case.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132136/new/

https://reviews.llvm.org/D132136

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to