beanz added inline comments.
================ Comment at: clang/lib/CodeGen/CGHLSLRuntime.cpp:103 + << NumThreadsAttr->getZ(); + OS.flush(); + F->addFnAttr(NumThreadsKindStr, NumThreadsStr); ---------------- You can replace this whole chunk of code with: ``` std::string NumThreadsStr = llvm::formatv("{0},{1},{2}", NumThreadsAttr->getX(), NumThreadsAttr->getY(), NumThreadsAttr->getZ()).str(); ``` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131799/new/ https://reviews.llvm.org/D131799 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits