jakev added inline comments.

================
Comment at: test/Profile/gcc-flag-compatibility.c:10
@@ -9,3 +9,3 @@
 
-// Check that -fprofile-generate uses the runtime default profile file.
+// Check that -fprofile-generate overrides the default profraw.
 // RUN: %clang %s -c -S -o - -emit-llvm -fprofile-generate | FileCheck 
-check-prefix=PROFILE-GEN %s
----------------
davidxl wrote:
> Please add a FIXME here. I noticed that there is a bug in IR PGO 
> implementation that -fprofile-generate still invokes overrider api in 
> instrumentation which is unnecessary.
I actually have a patch that fixes this behavior. I can post it once this patch 
has landed.


Repository:
  rL LLVM

https://reviews.llvm.org/D21823



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to