arichardson added inline comments.
================
Comment at: cmake/Modules/GNUBinaryDirs.cmake:6
+if (NOT DEFINED CMAKE_BINARY_BINDIR)
+ set(CMAKE_BINARY_BINDIR "${CMAKE_BINARY_BINDIR}/bin")
+endif()
----------------
I find this name a bit confusing, maybe something like `CMAKE_BUILD_BINDIR`
(and the same for _LIBDIR/_INCLUDEDIR would be less surprising? That way it's
clear that we are referring to binaries/libraries/includes in the build output
(and it mirrors CMAKE_INSTALL_INCLUDEDIR, etc.)
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D132608/new/
https://reviews.llvm.org/D132608
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
