aaron.ballman added reviewers: aaron.ballman, clang-language-wg.
aaron.ballman added a comment.
Thanks for this! Can you add some more details to the patch description so it's
more clear from there why the patch is necessary? Also, can you add a release
note for the fix?
I'm pretty sure the changes here are correct, but I want to take another run at
the standards wording to be sure.
================
Comment at: clang/lib/AST/ExprConstant.cpp:931
+ /// TODO: add doc.
+ bool AccessingStaticConstantDataMember = false;
----------------
Add the docs?
================
Comment at: clang/lib/AST/ExprConstant.cpp:8741-8743
+ if (Info.AccessingStaticConstantDataMember) {
+ return Success(E);
+ }
----------------
================
Comment at: clang/test/SemaCXX/cxx2a-consteval.cpp:925
+}
\ No newline at end of file
----------------
You should add a new line back to the end of the file.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D132398/new/
https://reviews.llvm.org/D132398
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
